From f9c8ca5df2457a541f70923a406719c3706c9d6d Mon Sep 17 00:00:00 2001 From: Erik Ritter Date: Sun, 2 Feb 2020 09:13:25 -0800 Subject: [PATCH] [SQL Lab] Improve autocomplete performance (#9064) --- superset/assets/src/SqlLab/components/AceEditorWrapper.jsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/superset/assets/src/SqlLab/components/AceEditorWrapper.jsx b/superset/assets/src/SqlLab/components/AceEditorWrapper.jsx index 3c2101e1b..aa31827d6 100644 --- a/superset/assets/src/SqlLab/components/AceEditorWrapper.jsx +++ b/superset/assets/src/SqlLab/components/AceEditorWrapper.jsx @@ -155,7 +155,12 @@ class AceEditorWrapper extends React.PureComponent { }); }, }; - const words = this.state.words.map(word => ({ ...word, completer })); + // Mutate instead of object spread here for performance + const words = this.state.words.map(word => { + /* eslint-disable-next-line no-param-reassign */ + word.completer = completer; + return word; + }); callback(null, words); } setAutoCompleter(props) {