From f9db605e0d96ed91426100309a0168e22bfb2d59 Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Wed, 10 Apr 2019 09:24:45 -0700 Subject: [PATCH] fix: make SIPs exempt from stale bots (#7278) * fix: make SIPs exempt from stale bots * update pr template --- .github/PULL_REQUEST_TEMPLATE.md | 23 ++++++++++++++++------- .github/stale.yml | 7 ++++--- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 424096291..d0984a7aa 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,22 +1,31 @@ -##### SUMMARY +### CATEGORY + +Choose one + +- [ ] Bug Fix +- [ ] Enhancement (new features, refinement) +- [ ] Refactor +- [ ] Add tests +- [ ] Build / Development Environment +- [ ] Documentation + +### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN - + ### ADDITIONAL INFORMATION - + - [ ] Has associated issue: - [ ] Changes UI -- [ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested. +- [ ] Requires DB Migration. +- [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- [ ] Fixes bug -- [ ] Refactors code -- [ ] Adds test(s) ### REVIEWERS diff --git a/.github/stale.yml b/.github/stale.yml index b6b56de6f..bf5e23ad2 100644 --- a/.github/stale.yml +++ b/.github/stale.yml @@ -4,7 +4,7 @@ daysUntilStale: 60 daysUntilClose: 7 # Issues with these labels will never be considered stale exemptLabels: - - "SIP" + - "#SIP" - ".pinned" - ".security" # Label to use when marking an issue as stale @@ -12,7 +12,8 @@ staleLabel: inactive # Comment to post when marking an issue as stale. Set to `false` to disable markComment: > This issue has been automatically marked as stale because it has not had - recent activity. It will be closed if no further activity occurs. Thank you - for your contributions. + recent activity. It will be closed if no further activity occurs. + Thank you for your contributions. For admin, please label this issue `.pinned` + to prevent stale bot from closing the issue. # Comment to post when closing a stale issue. Set to `false` to disable closeComment: false