diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/EchartsMixedTimeseries.tsx b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/EchartsMixedTimeseries.tsx
index 72cc64181..f319fb97a 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/EchartsMixedTimeseries.tsx
+++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/EchartsMixedTimeseries.tsx
@@ -95,12 +95,12 @@ export default function EchartsMixedTimeseries({
handleChange([seriesName], seriesIndex);
}
},
- mousemove: params => {
- currentSeries.name = params.seriesName;
- },
mouseout: () => {
currentSeries.name = '';
},
+ mouseover: params => {
+ currentSeries.name = params.seriesName;
+ },
};
return (
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx
index 0de436613..d30339185 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx
+++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx
@@ -283,30 +283,6 @@ const config: ControlPanelConfig = {
...legendSection,
[
{t('X Axis')}
],
['x_axis_time_format'],
- [
- {
- name: 'xAxisShowMinLabel',
- config: {
- type: 'CheckboxControl',
- label: t('Show Min Label'),
- default: true,
- renderTrigger: true,
- description: t('Show Min Label'),
- },
- },
- ],
- [
- {
- name: 'xAxisShowMaxLabel',
- config: {
- type: 'CheckboxControl',
- label: t('Show Max Label'),
- default: true,
- renderTrigger: true,
- description: t('Show Max Label'),
- },
- },
- ],
[
{
name: 'xAxisLabelRotation',
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts
index aecfd1f14..7c912e7fb 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts
+++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts
@@ -99,8 +99,6 @@ export default function transformProps(
tooltipTimeFormat,
yAxisFormat,
yAxisFormatSecondary,
- xAxisShowMinLabel,
- xAxisShowMaxLabel,
xAxisTimeFormat,
yAxisBounds,
yAxisIndex,
@@ -244,8 +242,6 @@ export default function transformProps(
nameGap: xAxisTitleMargin,
nameLocation: 'middle',
axisLabel: {
- showMinLabel: xAxisShowMinLabel,
- showMaxLabel: xAxisShowMaxLabel,
formatter: xAxisFormatter,
rotate: xAxisLabelRotation,
},
@@ -282,14 +278,14 @@ export default function transformProps(
appendToBody: true,
trigger: richTooltip ? 'axis' : 'item',
formatter: (params: any) => {
- const value: number = !richTooltip ? params.value : params[0].value[0];
- const prophetValue: any[] = !richTooltip ? [params] : params;
+ const xValue: number = richTooltip ? params[0].value[0] : params.value[0];
+ const prophetValue: any[] = richTooltip ? params : [params];
if (richTooltip && tooltipSortByMetric) {
prophetValue.sort((a, b) => b.data[1] - a.data[1]);
}
- const rows: Array = [`${tooltipTimeFormatter(value)}`];
+ const rows: Array = [`${tooltipTimeFormatter(xValue)}`];
const prophetValues = extractProphetValuesFromTooltipParams(prophetValue);
Object.keys(prophetValues).forEach(key => {
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/types.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/types.ts
index e78c2c7f7..a16c596aa 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/types.ts
+++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/types.ts
@@ -57,8 +57,6 @@ export type EchartsMixedTimeseriesFormData = QueryFormData & {
zoomable: boolean;
richTooltip: boolean;
xAxisLabelRotation: number;
- xAxisShowMinLabel?: boolean;
- xAxisShowMaxLabel?: boolean;
colorScheme?: string;
// types specific to Query A and Query B
area: boolean;
@@ -127,8 +125,6 @@ export const DEFAULT_FORM_DATA: EchartsMixedTimeseriesFormData = {
yAxisIndexB: 0,
groupby: [],
groupbyB: [],
- xAxisShowMinLabel: TIMESERIES_DEFAULTS.xAxisShowMinLabel,
- xAxisShowMaxLabel: TIMESERIES_DEFAULTS.xAxisShowMaxLabel,
zoomable: TIMESERIES_DEFAULTS.zoomable,
richTooltip: TIMESERIES_DEFAULTS.richTooltip,
xAxisLabelRotation: TIMESERIES_DEFAULTS.xAxisLabelRotation,
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
index 713a487b8..90639e65b 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
+++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
@@ -268,14 +268,14 @@ export default function transformProps(
appendToBody: true,
trigger: richTooltip ? 'axis' : 'item',
formatter: (params: any) => {
- const value: number = !richTooltip ? params.value : params[0].value[0];
- const prophetValue: any[] = !richTooltip ? [params] : params;
+ const xValue: number = richTooltip ? params[0].value[0] : params.value[0];
+ const prophetValue: any[] = richTooltip ? params : [params];
if (richTooltip && tooltipSortByMetric) {
prophetValue.sort((a, b) => b.data[1] - a.data[1]);
}
- const rows: Array = [`${tooltipFormatter(value)}`];
+ const rows: Array = [`${tooltipFormatter(xValue)}`];
const prophetValues: Record =
extractProphetValuesFromTooltipParams(prophetValue);
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
index f8bc52765..e411dad34 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
+++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
@@ -178,12 +178,12 @@ export function transformSeries(
step: ['start', 'middle', 'end'].includes(seriesType as string) ? seriesType : undefined,
stack: stackId,
lineStyle,
- areaStyle: {
- opacity:
- forecastSeries.type === ForecastSeriesEnum.ForecastUpper || area
- ? opacity * areaOpacity
- : 0,
- },
+ areaStyle: area
+ ? {
+ opacity:
+ forecastSeries.type === ForecastSeriesEnum.ForecastUpper ? opacity * areaOpacity : 0,
+ }
+ : undefined,
emphasis,
showSymbol,
symbolSize: markerSize,
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/types.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/types.ts
index d1d550ee7..060e43950 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/types.ts
+++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/types.ts
@@ -70,8 +70,6 @@ export type EchartsTimeseriesFormData = QueryFormData & {
tooltipTimeFormat?: string;
truncateYAxis: boolean;
yAxisFormat?: string;
- xAxisShowMinLabel?: boolean;
- xAxisShowMaxLabel?: boolean;
xAxisTimeFormat?: string;
timeGrainSqla?: TimeGranularity;
yAxisBounds: [number | undefined | null, number | undefined | null];