fix: Error when downgrading add_catalog_perm_to_tables migration (#29906)

This commit is contained in:
Michael S. Molina 2024-08-09 14:11:55 -04:00 committed by GitHub
parent b323bf0fb6
commit fb7f50868d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 20 deletions

View File

@ -29,27 +29,17 @@ from alembic import op
revision = "5f57af97bc3f" revision = "5f57af97bc3f"
down_revision = "d60591c5515f" down_revision = "d60591c5515f"
tables = ["tables", "query", "saved_query", "tab_state", "table_schema"]
def upgrade(): def upgrade():
op.add_column("tables", sa.Column("catalog", sa.String(length=256), nullable=True)) for table in tables:
op.add_column("query", sa.Column("catalog", sa.String(length=256), nullable=True)) op.add_column(
op.add_column( table,
"saved_query", sa.Column("catalog", sa.String(length=256), nullable=True),
sa.Column("catalog", sa.String(length=256), nullable=True), )
)
op.add_column(
"tab_state",
sa.Column("catalog", sa.String(length=256), nullable=True),
)
op.add_column(
"table_schema",
sa.Column("catalog", sa.String(length=256), nullable=True),
)
def downgrade(): def downgrade():
op.drop_column("table_schema", "catalog") for table in reversed(tables):
op.drop_column("tab_state", "catalog") op.drop_column(table, "catalog")
op.drop_column("saved_query", "catalog")
op.drop_column("query", "catalog")
op.drop_column("tables", "catalog")

View File

@ -48,6 +48,6 @@ def upgrade():
def downgrade(): def downgrade():
downgrade_catalog_perms(engines={"postgresql"})
op.drop_column("slices", "catalog_perm") op.drop_column("slices", "catalog_perm")
op.drop_column("tables", "catalog_perm") op.drop_column("tables", "catalog_perm")
downgrade_catalog_perms(engines={"postgresql"})