From ffff3e4bf4e7e92a1b8cec2be5aedfbb8e173a45 Mon Sep 17 00:00:00 2001 From: Cody Leff Date: Thu, 1 Dec 2022 02:56:11 -0700 Subject: [PATCH] fix(native-filters): Add empty text node before OutPortal (#22289) --- .../FilterBar/FilterControls/FilterControls.tsx | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx index c45b54ebe..f0d30a3b7 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx @@ -90,7 +90,14 @@ const FilterControls: FC = ({ const renderer = useCallback( ({ id }: Filter | Divider) => { const index = filtersWithValues.findIndex(f => f.id === id); - return ; + return ( + // Empty text node is to ensure there's always an element preceding + // the OutPortal, otherwise react-reverse-portal crashes + + {'' /* eslint-disable-line react/jsx-curly-brace-presence */} + + + ); }, [filtersWithValues, portalNodes], );