Commit Graph

56 Commits

Author SHA1 Message Date
Diego Medina b94052e438
chore: migrate /sql_json and /results to apiv1 (#22809) 2023-01-30 11:02:34 -05:00
JUST.in DO IT 0045816772
fix(sqllab): reverts #22695 (#22861) 2023-01-26 14:15:42 -07:00
JUST.in DO IT d591cc8082
fix(sqllab): Invalid schema fetch for deprecated value (#22695) 2023-01-19 10:19:17 -07:00
Diego Medina 3ed288d4ee
chore: Migrate /superset/stop_query/ to API v1 (#22624) 2023-01-16 14:07:52 +00:00
Ville Brofeldt b6d39d194c
feat(trino): support early cancellation of queries (#22498) 2022-12-24 06:31:46 +02:00
JUST.in DO IT c3f1873c43
fix(sqllab): Add templateParams on kv store (#22013) 2022-11-14 10:46:21 -08:00
Daniel Vaz Gaspar 7c6fabb033
chore: deprecate /superset/fetch_datasource_metadata mig to API v1 (#22102) 2022-11-14 08:51:26 +00:00
JUST.in DO IT 40024064ae
fix: BIGINT rendering regression in chartAction (#21937) 2022-10-26 15:04:20 -07:00
JUST.in DO IT 0c461497ff
chore(sqllab): refactor addQueryEditor for new tab (#21711) 2022-10-07 17:57:39 -03:00
Mayur 61319fd759
feat(sqllab): save query parameters in database (#21682) 2022-10-07 12:49:14 +05:30
JUST.in DO IT 222f1e7ea8
fix(sqllab): invalid table metadata request (#21304) 2022-09-01 16:35:19 -07:00
AAfghahi a7fe4850ed
fix: dataset exists error in save Dataset modal (#21244)
* dataset exists error

* fixed flashing modal
2022-08-31 16:47:39 -04:00
JUST.in DO IT f77b910e2c
perf(sqllab): Rendering perf improvement using immutable state (#20877)
* perf(sqllab): Rendering perf improvement using immutable state

- keep queryEditors immutable during active state
- add unsavedQueryEditor to store all active changes
- refactor each component to subscribe the related unsaved editor state only

* revert ISaveableDatasource type cast

* missing trigger prop

* a default of an empty object and optional operator
2022-08-23 12:17:19 -03:00
Diego Medina 15b9f83150
chore: support trailing slashes in database api (#21123) 2022-08-22 15:15:04 +08:00
Eric Briscoe ab6ec89f68
fix: [sc-54864] Adds safety check to provide near term fix to save query (#21034)
* [sc-54864] Adds safety check to provide near term fix for Queries not saving

There is an error when casting the columns array to String() for saving queries where the objects in the array are missing the toString method.   This is a near term rapid patch to fix workflow in production which will have a follow up to identify root cause.

* fix typo

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Adjusted chekc to be explicit for undefined instead of truthy

This fixes issue caught by unit test where the if statement was using a truthy check where it should be explicitly checking for value of undefined

* Adds new unit test to get 100% coverage for callApi

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-08-10 10:33:47 -07:00
Lyndsi Kay Williams 8a04536f9d
feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)
* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
2022-08-01 14:36:34 -05:00
Diego Medina 115ab700df
fix(sql lab): MultiSelector component render twice (#20706)
* fix(sql lab): MultiSelector component render twice

* filter null/undefined tables
2022-07-19 08:33:15 -03:00
Michael S. Molina 834dcef993
chore: Moves date utils to utils folder (#20192) 2022-05-31 12:21:58 -03:00
Diego Medina 653cf773f7
fix(sql lab): SQL Lab Compile Query Delay (#20206) 2022-05-27 09:42:01 +03:00
Daniel Vaz Gaspar 87a4379d0a
feat: deprecate /superset/validate_sql_json migrate to api v1 (#19935)
* feat: deprecate /superset/validate_sql_json migrate to api v1

* use new error handling

* migrate SQLLAb frontend and add tests

* debug test

* debug test

* fix frontend test on sqllab

* fix tests

* fix frontend test on sqllab

* fix tests

* fix tests

* fix tests

* fix tests
2022-05-10 21:25:39 +01:00
Daniel Vaz Gaspar 4fdf230a56
feat: deprecate /superset/extra_table_metadata migrate to api v1 (#19921)
* feat: deprecate /superset/extra_table_metadata migrate to api v1

* use can_read to table_extra_metadata

* troubleshoot sqlite

* fix test

* fix test

* fix test

* fix frontend test on sqllab
2022-05-04 14:55:52 +01:00
Diego Medina 800ced5e25
fix(sql lab): when editing a saved query, the status is lost when switching tabs (#19448) 2022-04-22 15:23:30 -06:00
Ville Brofeldt 87d47987b7
fix(sql-lab): do not replace undefined schema with empty object (#19664) 2022-04-12 15:13:03 +03:00
Ville Brofeldt 2d81c4c79f
fix(sqllab): null database with backend persistence (#19548) 2022-04-06 12:32:41 +03:00
Diego Medina 4669b6ce11
fix: most Recently Selected Table Should Appear at the Top of the List on the Left Panel (#19258) 2022-03-21 15:58:23 -06:00
cccs-Dustin 02ef9ca4cd
feat(sqllab): Add a configuration option to disable data preview (#19104) 2022-03-17 15:22:57 +02:00
maltoze 57c4d0f9a4
fix: passing url params in sqllab (#15246)
* fix: passing url params in sqllab

* avoid undefined serach and add test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-15 13:18:04 +02:00
Phillip Kelley-Dotson 9c08bc0ffc
fix: change database database selector (#18609)
* fix: change database selector

* fix lint
2022-02-08 12:22:20 -05:00
Phillip Kelley-Dotson 151d30bea4
fix: sqllab schema select error msg (#18564)
* fix: sqllab schema select error msg

* remove console logs

* fix lint
2022-02-04 10:21:18 -08:00
AAfghahi 88db2cc0ab
refactor(sql_lab): SQL Lab Persistent Saved State (#17771)
* a lot of console logs

* testing

* test

* added saved_query to remoteId

* created useEffect so that title properly changes in modal

* Update superset-frontend/src/SqlLab/actions/sqlLab.js

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-01-18 13:10:31 -05:00
Holger Bruch 6604a6ab28
chore(translations): Add missing i18n (#17525)
* Add *.ts to babel.cfg

* Add missing i18n calls

* Update pot file

* Fix lint issues and review comment

* Incorparate review feedback

* Fix missing or non-extractable i18n calls

* Update pot file

* Fix syntax error in CommonParameters.tsx

* Fix introduced issues
2021-11-27 14:50:33 +02:00
Michael S. Molina 9b17e86b44
chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00
Elizabeth Thompson f032cc254c
fix shared query (#16753) 2021-09-21 09:38:23 -07:00
Elizabeth Thompson 519baa6f00
fix: params in sql lab are jumpy in the ace editor (#16536)
* fix jumpy params

* remove cypress tests
2021-09-07 09:38:45 -07:00
AAfghahi ee2eccdb67
fix: queryEditor bug (#16452)
* queryEditor bug

* update tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-26 15:20:02 -07:00
Beto Dealmeida b489cffb57
fix: no lazy translation on SupersetError (#15669)
* fix: no lazy translation on SupersetError

* Small fixes
2021-07-14 16:54:11 -07:00
Beto Dealmeida 65f90096fd
fix: use encodeURIComponent when getting table metadata (#14790) 2021-05-24 12:20:31 -07:00
Hugh A. Miles II 0d240c3841
fix: properly keep state on queryEditorSetSql on tabstateview PUT (#14579)
* send queryid up with setSQL

* pass latest query id

* update

* cleanup
2021-05-12 15:20:26 -04:00
AAfghahi df9352f2b4
fix: data column in SQL lab left panel open by default (#13624)
* fix table expand

* Left Panel Expand

* added tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-03-18 13:28:24 -07:00
Elizabeth Thompson b97bbed2a9
fix: allow option to generate new query (#13488) 2021-03-18 14:42:31 -04:00
Dmytro Mudrov 72d19b6b35
fix(sqllab): Table name and schema are encoded twice during fetching table metadata on SQL Lab page. (#13636)
Co-authored-by: dmitry.mudrov <dmitrym.mudrov@agileengine.com>
2021-03-16 19:18:08 -07:00
Beto Dealmeida 8d48d2e37b
fix(sqllab): per-tab hide left bar (#13288)
* fix (sqllab): per-tab hide left bar

* Load state when switching tabs
2021-03-05 11:16:11 -08:00
Beto Dealmeida ab3f4bd94b
feat: add separate endpoint to fetch function names for autocomplete (#12840)
* WIP

* Add unit test for API

* Add spec

* Fix unit test

* Fix unit test

* Fix test

* Fix test

* Add period to error message
2021-02-02 18:01:01 -08:00
Michael S. Molina d9388d4535
Apply capitalization guidelines - iteration 7 (#12343) (#12453) 2021-01-21 21:46:06 -08:00
Michael S. Molina c85b4c75b1
Fix translation files and update documentation (#12595) 2021-01-20 10:50:24 -08:00
Hugh A. Miles II 68fe2208ba
fix: save tabs when saving the query bug (#12607)
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-01-19 14:27:48 -05:00
Rob DiCiuccio 4d329071a1
feat(SIP-39): Async query support for charts (#11499)
* Generate JWT in Flask app

* Refactor chart data API query logic, add JWT validation and async worker

* Add redis stream implementation, refactoring

* Add chart data cache endpoint, refactor QueryContext caching

* Typing, linting, refactoring

* pytest fixes and openapi schema update

* Enforce caching be configured for async query init

* Async query processing for explore_json endpoint

* Add /api/v1/async_event endpoint

* Async frontend for dashboards [WIP]

* Chart async error message support, refactoring

* Abstract asyncEvent middleware

* Async chart loading for Explore

* Pylint fixes

* asyncEvent middleware -> TypeScript, JS linting

* Chart data API: enforce forced_cache, add tests

* Add tests for explore_json endpoints

* Add test for chart data cache enpoint (no login)

* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag

* Add tests for tasks/async_queries and address PR comments

* Bypass non-JSON result formats for async queries

* Add tests for redux middleware

* Remove debug statement

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Skip force_cached if no queryObj

* SunburstViz: don't modify self.form_data

* Fix failing annotation test

* Resolve merge/lint issues

* Reduce polling delay

* Fix new getClientErrorObject reference

* Fix flakey unit tests

* /api/v1/async_event: increment redis stream ID, add tests

* PR feedback: refactoring, configuration

* Fixup: remove debugging

* Fix typescript errors due to redux upgrade

* Update UPDATING.md

* Fix failing py tests

* asyncEvent_spec.js -> asyncEvent_spec.ts

* Refactor flakey Python 3.7 mock assertions

* Fix another shared state issue in Py tests

* Use 'sub' claim in JWT for user_id

* Refactor async middleware config

* Fixup: restore FeatureFlag boolean type

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-12-10 20:21:56 -08:00
Jesse Yang 9a59bdda48
refactor: merge/upgrade superset-ui packages (#10790)
* refactor: merge/upgrade superset-ui packages

* Fix flaky big number test

* Fix Flaky AdhocFilters test
2020-09-09 13:18:55 -07:00
Erik Ritter 09de805017
chore: enable no-unused-vars and prefer-template eslint rules (#10350) 2020-07-16 19:13:59 -07:00
Erik Ritter 9a5195ab85
feat: support new errors payload in SQL Lab (#10243) 2020-07-06 09:49:32 -07:00