ESLint: Re-enable rule no-unused-vars (#10865)

* Re-enable rule no-unused-vars

* fixup! Re-enable rule no-unused-vars

superset-frontend/.eslintrc.js

@@ -60,7 +60,6 @@ module.exports = {
         '@typescript-eslint/no-empty-function': 0,
         '@typescript-eslint/no-explicit-any': 0,
         '@typescript-eslint/no-use-before-define': 1, // disabled temporarily
-        '@typescript-eslint/no-unused-vars': 0, // disabled temporarily
         '@typescript-eslint/explicit-function-return-type': 0,
         '@typescript-eslint/explicit-module-boundary-types': 0, // re-enable up for discussion
         camelcase: 0,

superset-frontend/src/components/Menu/MenuObject.tsx

@@ -39,7 +39,6 @@ export interface MenuObjectProps {
 
 export default function MenuObject({
   label,
-  icon,
   childs,
   url,
   index,

superset-frontend/src/explore/components/PropertiesModal.tsx

@@ -60,21 +60,6 @@ export type WrapperProps = InternalProps & {
   animation?: boolean; // for the modal
 };
 
-export default function PropertiesModalWrapper({
-  show,
-  onHide,
-  animation,
-  slice,
-  onSave,
-}: WrapperProps) {
-  // The wrapper is a separate component so that hooks only run when the modal opens
-  return (
-    <Modal show={show} onHide={onHide} animation={animation} bsSize="large">
-      <PropertiesModal slice={slice} onHide={onHide} onSave={onSave} />
-    </Modal>
-  );
-}
-
 function PropertiesModal({ slice, onHide, onSave }: InternalProps) {
   const [submitting, setSubmitting] = useState(false);
   const errorDialog = useRef<any>(null);
@@ -279,3 +264,18 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) {
     </form>
   );
 }
+
+export default function PropertiesModalWrapper({
+  show,
+  onHide,
+  animation,
+  slice,
+  onSave,
+}: WrapperProps) {
+  // The wrapper is a separate component so that hooks only run when the modal opens
+  return (
+    <Modal show={show} onHide={onHide} animation={animation} bsSize="large">
+      <PropertiesModal slice={slice} onHide={onHide} onSave={onSave} />
+    </Modal>
+  );
+}