iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: avoid undefined property on `Global` type (#21631)

This commit is contained in:
JUST.in DO IT 2022-10-02 19:51:55 -07:00 committed by GitHub
parent ef78ec6b30
commit 157482955e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/packages/superset-ui-switchboard/src/switchboard.test.ts
View File

@ -105,7 +105,9 @@ describe('comms', () => {
let originalConsoleError: any = null;
beforeAll(() => {
global.MessageChannel = FakeMessageChannel; // yolo
Object.defineProperty(global, 'MessageChannel', {
value: FakeMessageChannel,
});
originalConsoleDebug = console.debug;
originalConsoleError = console.error;
});

2
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
View File

@ -283,7 +283,7 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
setBarTopOffset(headerRef.current?.getBoundingClientRect()?.height || 0);
let observer: ResizeObserver;
if (typeof global.ResizeObserver !== 'undefined' && headerRef.current) {
if (global.hasOwnProperty('ResizeObserver') && headerRef.current) {
observer = new ResizeObserver(entries => {
setBarTopOffset(
current => entries?.[0]?.contentRect?.height || current,