iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Typo fixes in viz.py and CONTRIBUTING.md (#5432)

This commit is contained in:
Vishal Jagtap 2018-07-20 05:15:56 +05:30 committed by timifasubaa
parent 99ce7b79fa
commit 6441f69271
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@ -493,7 +493,7 @@ https://github.com/apache/incubator-superset/pull/3013
In the future we'll start publishing release candidates for minor releases
only, but typically not for micro release.
The process will be similar to the process described above, expect the
tags will be formated `0.25.0rc1`, `0.25.0rc2`, ..., until consensus
tags will be formatted `0.25.0rc1`, `0.25.0rc2`, ..., until consensus
is reached.
We should also have a Github PR label process to target the proper

8
superset/viz.py
View File

@ -86,7 +86,7 @@ class BaseViz(object):
self.force = force
# Keeping track of whether some data came from cache
# this is useful to trigerr the <CachedLabel /> when
# this is useful to trigger the <CachedLabel /> when
# in the cases where visualization have many queries
# (FilterBox for instance)
self._some_from_cache = False
@ -129,7 +129,7 @@ class BaseViz(object):
return data
def run_extra_queries(self):
"""Lyfecycle method to use when more than one query is needed
"""Lifecycle method to use when more than one query is needed
In rare-ish cases, a visualization may need to execute multiple
queries. That is the case for FilterBox or for time comparison
@ -156,7 +156,7 @@ class BaseViz(object):
df = df.fillna(fillna)
def get_fillna_for_col(self, col):
"""Returns the value for use as filler for a specific Column.type"""
"""Returns the value to use as filler for a specific Column.type"""
if col:
if col.is_string:
return ' NULL'
@ -323,7 +323,7 @@ class BaseViz(object):
We remove datetime bounds that are hard values,
and replace them with the use-provided inputs to bounds, which
may we time-relative (as in "5 days ago" or "now").
may be time-relative (as in "5 days ago" or "now").
"""
cache_dict = copy.copy(query_obj)