iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: dashboard DAO small code improvement (#23348)

This commit is contained in:
Daniel Vaz Gaspar 2023-03-13 18:03:02 +00:00 committed by GitHub
parent f3055fcaff
commit b99d38dfef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
superset/dashboards/dao.py
View File

@ -39,8 +39,8 @@ class DashboardDAO(BaseDAO):
model_cls = Dashboard
base_filter = DashboardAccessFilter
@staticmethod
def get_by_id_or_slug(id_or_slug: Union[int, str]) -> Dashboard:
@classmethod
def get_by_id_or_slug(cls, id_or_slug: Union[int, str]) -> Dashboard:
query = (
db.session.query(Dashboard)
.filter(id_or_slug_filter(id_or_slug))
@ -50,7 +50,7 @@ class DashboardDAO(BaseDAO):
.outerjoin(Dashboard.roles)
)
# Apply dashboard base filters
query = DashboardAccessFilter("id", SQLAInterface(Dashboard, db.session)).apply(
query = cls.base_filter("id", SQLAInterface(Dashboard, db.session)).apply(
query, None
)
dashboard = query.one_or_none()